Add an option to scrub some sensitive headers from external json requests #4878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydoane
approved these changes
Nov 28, 2023
…ests We're already doing it for the cached request object in the process dictionary so it makes sense to do it for the external json requests as well. For compatibility, allow reverting to previous behavior using the `[chttpd] scrub_json_request` config setting.
nickva
force-pushed
the
backport-more-main-commits-to-3.3.x
branch
from
cd38460
to
96ac56c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're already doing it for the cached request object in the process dictionary so it makes sense to do it for the external json requests as well.
For compatibility, allow reverting to previous behavior using the
[chttpd] scrub_json_requestconfig setting.This is a backport from main to 3.3.x