include mrview options in _explain result #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willholley
force-pushed
the
mango_explain_view_parameters
branch
from
b458de2
to
ec5f24e
Compare
iilyak
reviewed
Sep 1, 2017
| {end_key, mango_idx:end_key(Idx, Ranges)} | ||
| ]}}] | ||
| end. | ||
|
|
There was a problem hiding this comment.
Previous implementation returned range property as well. We don't return it anymore. Would it be a problem for fauxton?
There was a problem hiding this comment.
fauxton just displays the raw JSON result from _explain, so it won't be a problem. The range property is now part of the mrargs object in the result.
iilyak
reviewed
Sep 1, 2017
There was a problem hiding this comment.
I have a question about compatibility with fauxton. Tests pass locally though.
nosetests -vv test/02-basic-find-test.py
....
test_explain_view_args (02-basic-find-test.BasicFindTests) ... ok
...
-------------------------------------------------------
Ran 22 tests in 2.796s
OK
_explain previously returned the options passed in by the user but not those modified at execution time by Mango. Now we include index-specific options (mrargs for map/reduce indexes) in the output, allowing us to see e.g. when include_docs was used.
willholley
force-pushed
the
mango_explain_view_parameters
branch
from
ec5f24e
to
ad29220
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
_explainpreviously returned the options passed in by the user butnot those modified at execution time by Mango. Now we include
index-specific options (mrargs for map/reduce indexes) in the output,
allowing us to see e.g. when include_docs was used.
Testing recommendations
Manually test by making a request to the
_explainendpoint from the command line / Fauxton. When a query is fulfilled by ajsonindex, you should see anmrargsfield in the output.Unit tests should provide good coverage.
GitHub issue number
Related Pull Requests
Checklist