Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ScalarValue::IntervalMonthDayNano -> String Support #10795

Closed
phillipleblanc opened this issue Jun 5, 2024 · 0 comments · Fixed by #10956
Closed

Implement ScalarValue::IntervalMonthDayNano -> String Support #10795

phillipleblanc opened this issue Jun 5, 2024 · 0 comments · Fixed by #10956
Labels
enhancement New feature or request

Comments

@phillipleblanc
Copy link
Contributor

Is your feature request related to a problem or challenge?

Part of #9494 to complete support for Unparsing LogicalPlan to SQL String.

Converting LogicalPlans back to SQL is valuable for several usecases such as using DataFusion in federated databases (e.g. generate SQL to push down) or using DataFusion's expr APIs to programmatically create SQL.

Describe the solution you'd like

Support converting SQL syntax that includes predicates with scalar values, like the following TPCH query:

select
    o_orderpriority,
    count(*) as order_count
from
    orders
where
        o_orderdate >= '1993-07-01'
  and o_orderdate < date '1993-07-01' + interval '3' month
  and exists (
        select
            *
        from
            lineitem
        where
                l_orderkey = o_orderkey
          and l_commitdate < l_receiptdate
    )
group by
    o_orderpriority
order by
    o_orderpriority;

The logical plan derived from parsing the above query should be able to be turned back into SQL.

Describe alternatives you've considered

The basic pattern is:

Implement the Expr --> AST reverse code in Unparser::expr_to_sql(source link)
Add a test to expr_to_sql_ok
Note you can run the tests like

cargo test -p datafusion-sql -- expr_to_sql_ok

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant