Minor: Add routine to debug join fuzz tests #10970
Merged
+162
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jun 18, 2024
|
|
||
| // if debug flag is set the test will save randomly generated inputs and outputs to user folders | ||
| // so it is easy to run debug on top of the failed test data | ||
| if debug { |
There was a problem hiding this comment.
👍
It might make sense to add this information about saving information to the overall docstring of this function (run_tests) so people don't have to read the implementation to find out what debug does.
| @@ -383,7 +419,7 @@ impl JoinFuzzTestCase { | |||
|
|
|||
| /// Perform sort-merge join and hash join on same input | |||
| /// and verify two outputs are equal | |||
| async fn run_test(&self) { | |||
| async fn run_test(&self, join_test: &[JoinTest], debug: bool) { | |||
There was a problem hiding this comment.
Since this is already on a struct, another way to pass in the debug flag would be as a new field on JoinFuzzTestCase
like
struct JoinFuzzTestCase {
batch_sizes: &'static [usize],
input1: Vec<RecordBatch>,
input2: Vec<RecordBatch>,
join_type: JoinType,
join_filter_builder: Option<JoinFilterBuilder>,
// if debug flag is set the test will save randomly generated inputs and outputs to user folders
// so it is easy to run debug on top of the failed test data
debug: bool,
}| /// This method useful for debugging fuzz tests | ||
| /// It helps to save randomly generated input test data for both join inputs into the user folder | ||
| /// as a parquet files preserving partitioning. | ||
| /// Once the data is saved it is possible to run a custom test on top of the saved data and debug |
|
Thanks @alamb for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
It is pretty complicated to find the exact root cause for issues triggered by fuzz tests. Those tests have a random nature and sometime require stable things to reproduce the case especially when the test is flaky. Adding debug procedures and doc how to use then while debugging #10886
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?