Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move code to fold now() from Simplifier() to ConstEvaluator #1175

Closed
alamb opened this issue Oct 25, 2021 · 0 comments · Fixed by #1176
Closed

Move code to fold now() from Simplifier() to ConstEvaluator #1175

alamb opened this issue Oct 25, 2021 · 0 comments · Fixed by #1176
Assignees
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Oct 25, 2021

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
This is a follow on suggestion from @rdettai on #1153 https://github.com/apache/arrow-datafusion/pull/1153/files#r735437280

Namely the substitution of now() for the current value is better described as "constant evaluation" rather than "algebraic simplification" so it should be done in the ConstEvaluator code.

Describe the solution you'd like
Move code to fold now() from Simplifier() to ConstEvaluator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant