Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Time comparison #3157

Closed
waitingkuo opened this issue Aug 15, 2022 · 1 comment
Closed

Support Time comparison #3157

waitingkuo opened this issue Aug 15, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@waitingkuo
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and why for this feature, in addition to the what)

we now have time but cannot be compared yet

DataFusion CLI v10.0.0
❯ select time '00:00:00';
+----------------------------------------------+
| CAST(Utf8("00:00:00") AS Time64(Nanosecond)) |
+----------------------------------------------+
| 00:00:00                                     |
+----------------------------------------------+
1 row in set. Query took 0.045 seconds.

❯ select time '00:00:00' = time '00:00:00';
ArrowError(NotYetImplemented("Comparing arrays of type Time64(Nanosecond) is not yet implemented"))

Describe the solution you'd like
A clear and concise description of what you want to happen.

support comparison for Time64(Nanosecond)

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@alamb
Copy link
Contributor

alamb commented Sep 19, 2023

This query now works in datafusion 31:

DataFusion CLI v31.0.0
❯ select time '00:00:00' = time '00:00:00';
+-------------------------------------+
| Utf8("00:00:00") = Utf8("00:00:00") |
+-------------------------------------+
| true                                |
+-------------------------------------+
1 row in set. Query took 0.002 seconds.

Presumably due to all the work from @tustvold and @berkaysynnada getting these kernels in good shape

@alamb alamb closed this as completed Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants