Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI failed in Compare to postgres #4294

Closed
jackwener opened this issue Nov 19, 2022 · 4 comments · Fixed by #4296
Closed

CI failed in Compare to postgres #4294

jackwener opened this issue Nov 19, 2022 · 4 comments · Fixed by #4296
Labels
bug Something isn't working

Comments

@jackwener
Copy link
Member

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

Expected behavior
A clear and concise description of what you expected to happen.

Additional context
Add any other context about the problem here.

@jackwener jackwener added the bug Something isn't working label Nov 19, 2022
@jackwener
Copy link
Member Author

jackwener commented Nov 19, 2022

#4276 #4293

@alamb
Copy link
Contributor

alamb commented Nov 20, 2022

Example failure:

=================================== FAILURES ===================================
_ TestPsqlParity.test_sql_file[/home/runner/work/arrow-datafusion/arrow-datafusion/integration-tests/sqls/values_list.sql] _

self = <test_psql_parity.TestPsqlParity object at 0x7ff3ad617d30>
fname = PosixPath('/home/runner/work/arrow-datafusion/arrow-datafusion/integration-tests/sqls/values_list.sql')

    @pytest.mark.parametrize("fname", test_files, ids=str)
    def test_sql_file(self, fname):
        datafusion_output = pd.read_csv(io.BytesIO(generate_csv_from_datafusion(fname)))
        psql_output = pd.read_csv(io.BytesIO(generate_csv_from_psql(fname)))
>       np.testing.assert_allclose(datafusion_output, psql_output, equal_nan=True, verbose=True)

integration-tests/test_psql_parity.py:91: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/opt/hostedtoolcache/Python/3.10.8/x[64](https://github.com/apache/arrow-datafusion/actions/runs/3503739074/jobs/5869029028#step:9:65)/lib/python3.10/site-packages/numpy/__init__.py:309: in __getattr__
    import numpy.testing as testing
/opt/hostedtoolcache/Python/3.10.8/x64/lib/python3.10/site-packages/numpy/testing/__init__.py:12: in <module>
    from ._private import extbuild, decorators as dec
/opt/hostedtoolcache/Python/3.10.8/x64/lib/python3.10/site-packages/numpy/testing/_private/extbuild.py:11: in <module>
    from numpy.distutils.ccompiler import new_compiler
/opt/hostedtoolcache/Python/3.10.8/x64/lib/python3.10/site-packages/numpy/distutils/__init__.py:24: in <module>
    from . import ccompiler
/opt/hostedtoolcache/Python/3.10.8/x64/lib/python3.10/site-packages/numpy/distutils/ccompiler.py:20: in <module>
    from numpy.distutils import log
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

Maybe some package was updated in the python ecosystem and we need to update the harness to keep up 🤔

@jimexist any ideas?

@isidentical
Copy link
Contributor

@alamb it seems like this was caused because we do not pin setuptools (re: numpy/numpy/issues/22623). I'll send a PR shortly that includes a pin on our setuptools version as well!

@alamb
Copy link
Contributor

alamb commented Nov 20, 2022

Thank you @isidentical

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants