Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: small refactoring for ints/floats to timestamps conversions #8370

Closed
Tracked by #8282
comphead opened this issue Nov 30, 2023 · 2 comments · Fixed by #9500
Closed
Tracked by #8282

Minor: small refactoring for ints/floats to timestamps conversions #8370

comphead opened this issue Nov 30, 2023 · 2 comments · Fixed by #9500
Assignees
@comphead
Labels
enhancement New feature or request

Comments

@comphead
Copy link
Contributor

Is your feature request related to a problem or challenge?

Follow up on #8159 #8193

While implementing fixes for two tickets above there is a small tech debt which needs to be adressed

Describe the solution you'd like

Its needed to do a small refactoring on timestamp conversions

  • use arrow-rs cast kernel for Float -> Timestamp conversion
  • get rid of double cast on Integer -> Timestamp conversion

Describe alternatives you've considered

No response

Additional context

No response
@comphead comphead added the enhancement New feature or request label Nov 30, 2023
@comphead comphead self-assigned this Nov 30, 2023
@comphead comphead mentioned this issue Nov 30, 2023
Merged
@comphead
Copy link
Contributor Author

Depends on apache/arrow-rs#5123 to be released

@comphead comphead mentioned this issue Nov 30, 2023
Open
23 tasks
@alamb
Copy link
Contributor

alamb commented Jan 19, 2024

I think this may be fixed now

@comphead comphead mentioned this issue Mar 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@comphead comphead

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

minor: use arrow-rs casting from Float to Timestamp comphead/arrow-datafusion
2 participants
@alamb @comphead