[DELTASPIKE-1160] Enable other Entity types as return from native repository queries

[Danny02]

At the moment native queries can only return the same entity type as of the repository.

A special flag exist on the @query annotation to disable mapping, this enables the possibility to return unmapped types as String, Date or Integer.

This change uses the return type of the method with the @query annotation.
If the type is java.util.List, it uses the generic type.

It should be checked if this behaviour is correct for all JPA providers and if some special logging is needed.

This change also removes the flag from @query, I don't know if you want to retain it for backward compatibility reasons and mark it as deprecated.

[johnament]

HI Danny, good catch, thats what happens when I'm looking at this too late in the evening.

Can you please commit this all under the original ticket? and can you expand this method to check for collection types?

[Danny02]

sry, but which original ticket do you mean? DELTASPIKE-1089?

[johnament]

Either is fine, your commit message doesn't include a JIRA ticket.

[Danny02]

done

[johnament]

Looks good to me. If no one else gets to it, I'll merge this evening (EDT). Thanks for the contrib!

[johnament]

Hi Danny,

Just ran your changes against wildfly 10. Its failing for:

Tests in error: 
  should_query_names(org.apache.deltaspike.data.impl.handler.EntityRepositoryHandlerTest): org.hibernate.MappingException: Unknown entity: java.lang.String

I think this is the difference between the original patch and the new changes. I think the spec expects the class passed in to be an entity for a typed query. By not using a typed query, it uses fallback logic to plain JDBC column mapping.

Also, please rebase your changes from our master. Finally, please take a look at our contribution guide, specifically our code formatting. http://deltaspike.apache.org/documentation/source.html

Thanks!

[Danny02]

ah ok, I think one can check if the return type is a registered entity type with the entitymanager.
I will try this tomorrow.

[Danny02]

Hi,

I think everything should be fine now with the code (tested it on wildfly 10 & used eclipse formatter).

A quick question about constributing. Should I upload a patch file to Jira or can you merge the changes directly from GitHub to the ASF repository?

[johnament]

Please delete this parameter, just like in your original PR. This was only added this week to address this problem originally.

[Danny02]

Done, didn't notice that this was such recent code

[johnament]

Also, regarding your question, I'm fine with pulling the branch from GH into our repo.

[johnament]

Both TomEE 7 and Wildfly 10 fail on this test:

TomEE:

should_query_names(org.apache.deltaspike.data.impl.handler.EntityRepositoryHandlerTest): Column not found: 0

Wildfly:

should_query_names(org.apache.deltaspike.data.impl.handler.EntityRepositoryHandlerTest): org.hibernate.exception.SQLGrammarException: could not execute query

In addition, I had to fix a CS issue:

-    QueryHint[] hints() default {};
+    QueryHint[] hints() default { };

[Danny02]

Hi,

I removed some formatting changes I commited from code I didn't touch. I also finally removed the now unused Query paramter (forgot that).

On the point of failed tests. I'm sorry, but I can't reproduce them. I have run the following builds in './deltaspike/modules/data/impl':

• mvn clean test -P wildfly-build-managed -Dwildfly.version=10.0.0.Final
• mvn clean test -P tomee7-build-managed

and both are successfull

[johnament]

I'm not sure what happened, but its passing locally now, and I didn't see anything wrong explaining why it would fail. I've merged in, but had to rebase so if you wouldn't mind closing this PR. Thanks for the contribution!