Fixes for Payara mnaged profile #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,6 +19,7 @@ | |||
|
|
|||
| package org.apache.deltaspike.data.test.java8.test; | |||
|
|
|||
| import java.util.*; | |||
There was a problem hiding this comment.
Please correct the wildcard import.
|
Can you squash the commits? |
|
Also please reference the JIRA ticket https://issues.apache.org/jira/browse/DELTASPIKE-1181 |
|
I will squash the commits. I just wanted to separate fixes for multiple issues - every commit fixes a single issue. |
OndroMih
force-pushed
the
master
branch
2 times, most recently
from
9b59822
to
ec96970
Compare
https://issues.apache.org/jira/browse/DELTASPIKE-1181 - Fix of failing CDI test - Fix of missing profile for Payara in data module - Fix of Java 8 test
|
The commits are squashed now. I also fixed a compilation issue - the Java8 test project did not specify Java8 compilation target, so it took 1.6 from a parent POM. I'm not able to add reference to DELTASPIKE-1181 - I changed the commit message in my local repo, but force push does not update the commit message. |
|
Now the build is failing in Jenkins on some weird issue with mvn. The compilation error is gone though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I identified 3 issues when running
mvn clean install -Ppayara-build-managed-4:I'm sending PR for the 1st and 2nd issue. The 3rd issue remains - it seems that there is a problem with Jersey integration. Jersey cannot find a context for JNDI lookup, I will need to investigate further what is the reason. The following commit would fi the issue, but it effectively disables all the tests, as Payara Server 162 uses Weld 2.3.2.Final, which is out of specified range: 8166155