Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logout button in secured/home.xhtml #63

Closed
wants to merge 2 commits into from
Closed

add logout button in secured/home.xhtml #63

wants to merge 2 commits into from

Conversation

subaochen
Copy link
Contributor

add logout button in secured/home.xhtml page and logout action in
AuthenticationListener.java
move @secured annotation of Pages.java to folder,in order to protected
the whole folder

add logout button in secured/home.xhtml page and logout action in
AuthenticationListener.java
move @secured annotation of Pages.java to folder,in order to protected
the whole folder
@johnament
Copy link
Contributor

Hi Su!

First, thanks for the PR. Please create a JIRA describing your change - looks like you're updating our examples to include a logout link. Once you've done that, please amend your commit with the JIRA ticket #.

In addition, it looks like you have a checkstyle violation in your code.

@subaochen
Copy link
Contributor Author

I have created issue at: https://issues.apache.org/jira/browse/DELTASPIKE-1201, but I can not get the detail of the code checkstyle viloation, would you like to show some hints? I'm sorry, I know little about Jenkins, and can not get enough information from Jenkins.

Thanks a lot!

@johnament
Copy link
Contributor

This is what the output says

[INFO] --- maven-checkstyle-plugin:2.9.1:check (verify-style) @ deltaspike-security-requested-page-after-login-picketlink ---
[INFO] Starting audit...
/home/jenkins/jenkins-slave/workspace/DeltaSpike-PR-Builder/deltaspike/examples/security-requested-page-after-login-picketlink/src/main/java/org/apache/deltaspike/example/security/requestedpage/picketlink/AuthenticationListener.java:48:66: '{' should be on a new line.
Audit done.

[INFO] There are 1 checkstyle errors.
[INFO] -----------------------------------

You should compile the module locally as well.

@subaochen
Copy link
Contributor Author

hi johnament,

I have fixed the checkstyle violation. I often run mvn clean package but not mvn clean install , so check-style-plugin not working, will follow you guide next time, thanks again!

@johnament
Copy link
Contributor

Hi @subaochen you're correct, build looks good now. However, still need the commits to include the JIRA ticket in them and if you can squash them together that would be great.

@subaochen
Copy link
Contributor Author

hi @johnament , I have looked around git log of deltaspike to learn how to write the comment followed the deltaspike way. I'd like to close this PR and create a new PR again, ok?

@johnament
Copy link
Contributor

If you want you can, however you can also just git push -f after making your fixes locally. This page may give you more info as well.

@subaochen subaochen closed this Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants