DELTASPIKE-1207: fix exception handling in DynamicMBeanWrapper.invoke() #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove unnecessary cast to Exception
cause needs to be passed to MBeanException constructor, not e (and so casting is needed after all)
- don't wrap MBeanException directly thrown by the MBean method - document exception handling in @JmxManaged
|
Could you squash the commits? |
|
Well I guess I have to create an new branch in my repository then and I have to create a new pull request? |
|
The ASF doesn't give us direct write access to the mirror, its a one way sync from git-wip-us to github. Besides, its generally not good practice to do that since it breaks the commit history. You don't need to create a new branch, just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, this fix enables the transfer of a exception thrown by the MBean method to the client.
Tomorrow I'm going to update the JIRA ticket with some output examples.
Not sure about the logging removal, though. In my project we have a logging interceptor for MBeans which logs exceptions anyway so another log entry from DynamicMBeanWrapper just "pollutes" the logfile.
Exceptions aren't swallowed either, so ...