Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSIP-31] Reduce the connection pool size of hikari #15889

Closed
2 tasks done
Tracked by #14102
ruanwenjun opened this issue Apr 22, 2024 · 0 comments · Fixed by #15890
Closed
2 tasks done
Tracked by #14102

[DSIP-31] Reduce the connection pool size of hikari #15889

ruanwenjun opened this issue Apr 22, 2024 · 0 comments · Fixed by #15890
Assignees
Labels

Comments

@ruanwenjun
Copy link
Member

ruanwenjun commented Apr 22, 2024

Search before asking

  • I had searched in the DSIP and found no similar DSIP.

Motivation

I am not clear why we set the hikari thread pool size, I don't find out any benchmark test result.

Following https://github.com/brettwooldridge/HikariCP/wiki/About-Pool-Sizing, I hope to remove some configurations of hikari, the default setting is great enough. We shouldn't change the default setting unless we have benchmark evidence.

hikari:
connection-test-query: select 1
minimum-idle: 5
auto-commit: true
validation-timeout: 3000
pool-name: DolphinScheduler
maximum-pool-size: 50
connection-timeout: 30000
idle-timeout: 600000
leak-detection-threshold: 0
initialization-fail-timeout: 1

Design Detail

Only keep the pool name and connection-test-query
hikari:
connection-test-query: select 1
pool-name: DolphinScheduler

Compatibility, Deprecation, and Migration Plan

Compatible with all version.

Test Plan

Test by e2e.

Code of Conduct

@ruanwenjun ruanwenjun self-assigned this Apr 22, 2024
@ruanwenjun ruanwenjun changed the title [DSIP-31] Reduce the thread pool size of hikari [DSIP-31] Reduce the connection pool size of hikari Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant