Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][server] when an exception occurs in the taskExecuteThread, task cannot stop immediately #5132

Closed
xxjingcd opened this issue Mar 23, 2021 · 2 comments

Comments

@xxjingcd
Copy link
Contributor

Describe the bug

When an exception occurs in the taskExecuteThread, task will be called the cancelApplication() method to stop the task immediately。Howerver,the task whose cancelApplication() method base on the AbstractCommandExecutor.cancelApplication() cannot be killed immediately,because AbstractCommandExecutor.cancelApplication() would not call hardKill() method when soft kill process fail;

To Reproduce

Expected behavior
In order to make the error task stop immediately ,It should call the hardKill() method when soft kill process fails;

Screenshots
image

Which version of Dolphin Scheduler:
-[dev]

Additional context
It is a very simple Bug, the softKill() method returns the opposite state, so just modify the return value can fix this bug. I will fix this Bug.

Requirement or improvement

@xxjingcd
Copy link
Contributor Author

the PR: #5133

@CalvinKirs
Copy link
Member

close by #5133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants