Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Server] Support custom timezone #8310

Closed
7 tasks done
caishunfeng opened this issue Feb 8, 2022 · 8 comments
Closed
7 tasks done

[Feature][Server] Support custom timezone #8310

caishunfeng opened this issue Feb 8, 2022 · 8 comments
Labels
feature new feature

Comments

@caishunfeng
Copy link
Contributor

caishunfeng commented Feb 8, 2022

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

  • Unified config timezone by spring
    Now DS use the default timezone GMT+8, and add the @JsonFormat(pattern = "yyyy-MM-dd HH:mm:ss", timezone = "GMT+8") on date type field in many object, which is hard to unified timezone and change it.

  • Support custom timeone
    The api interface return datetime is string type, which lose the timezone info, the same for api requests, so maybe it should supply customize timezone for user.

    • After discussion, we think it's better to add timezone into user info config, and user can select other timezone freely. If no timezone is specified, default use timezone UTC +0:00.
    • UI support user to change timezone, default local timezone.
    • Handler timezone unified in server

Task List

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@caishunfeng caishunfeng added feature new feature Waiting for reply Waiting for reply labels Feb 8, 2022
@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Hi:

@jim-parsons
Copy link
Contributor

I think timezone is a non-hign-frequency property and it belongs application level so its not that necessary to customize it.
I check the code and some module like dolphinscheduler-api has the spring.jackson-timezone config.

@caishunfeng
Copy link
Contributor Author

caishunfeng commented Feb 9, 2022

I think timezone is a non-hign-frequency property and it belongs application level so its not that necessary to customize it.

Now DS use GTM+8 as default and it's hard to use in other countries, so it's a very important feature for development in other countries.

I check the code and some module like dolphinscheduler-api has the spring.jackson-timezone config.

Yes, and the json format annotation should be remove, unified timezone by spring config.

@jim-parsons
Copy link
Contributor

I think timezone is a non-hign-frequency property and it belongs application level so its not that necessary to customize it.

Now DS use GTM+8 as default and it's hard to use in other countries, so it's a very important feature for development in other countries.

I check the code and some module like dolphinscheduler-api has the spring.jackson-timezone config.

Yes, and the json format annotation should be remove, unified timezone by spring config.

got it. if the spring config solution is ok , assign it to me, thx~

@caishunfeng
Copy link
Contributor Author

Hi @tangchunbo I had split the sub issue. If you are interested in, please tell me, thx~

@jim-parsons
Copy link
Contributor

Hi @tangchunbo I had split the sub issue. If you are interested in, please tell me, thx~

ok, i‘ll do this issue. but i've got a question, how do l understand issue #8386 , add timezone into table t_ds_user ? plz help me out

@caishunfeng caishunfeng removed the Waiting for reply Waiting for reply label Feb 16, 2022
@caishunfeng
Copy link
Contributor Author

ok, i‘ll do this issue. but i've got a question, how do l understand issue #8386 , add timezone into table t_ds_user ? plz help me out
yes, add timezone field into table t_ds_user, and provides an interface to update timezone separately. what do you think? @tangchunbo

@jim-parsons
Copy link
Contributor

ok, i'll do the these issues's(#8385 , #8386 ) backend work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature
Projects
None yet
Development

No branches or pull requests

2 participants