Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][python] Add example about multi line shell #8955

Closed
2 of 3 tasks
Tracked by #5689
zhongjiajie opened this issue Mar 17, 2022 · 7 comments · Fixed by apache/dolphinscheduler-sdk-python#133
Closed
2 of 3 tasks
Tracked by #5689
Assignees
Labels
document enhancement New feature or request feature new feature good first issue good first issue help wanted Extra attention is needed Python
Milestone

Comments

@zhongjiajie
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

In all our examples in https://dolphinscheduler.apache.org/python/tasks/shell.html#example are single line. we should add example about how to create shell task in multiple lines

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@zhongjiajie zhongjiajie added enhancement New feature or request help wanted Extra attention is needed feature new feature good first issue good first issue Python document labels Mar 17, 2022
@github-actions
Copy link

Hi:

@zhongjiajie
Copy link
Member Author

And also string format

@zhongjiajie
Copy link
Member Author

better to add parameter for our example

@HarshitNagpal29
Copy link

HarshitNagpal29 commented Jan 9, 2024

@zhongjiajie sir please assign this issue to me, I will try my best to solve it, also can you just summarise what exactly I have to do as some of the links are not updated mentioned in this issue, it would be really helpful.

@HarshitNagpal29
Copy link

@zhongjiajie Sir, as I can understand from whatever information is provided that the DolphinScheduler documentation needs to be updated to include a detailed example illustrating how to create and execute a multi-line shell task within a Python context. This goes beyond the existing single-line examples, emphasizing the need to showcase more complex scenarios where shell commands or tasks in Python might extend over multiple lines of code. Am I right in comprehending this, if not then please specify anything which needs to be rectified along with this.

@zhongjiajie
Copy link
Member Author

@zhongjiajie Sir, as I can understand from whatever information is provided that the DolphinScheduler documentation needs to be updated to include a detailed example illustrating how to create and execute a multi-line shell task within a Python context. This goes beyond the existing single-line examples, emphasizing the need to showcase more complex scenarios where shell commands or tasks in Python might extend over multiple lines of code. Am I right in comprehending this, if not then please specify anything which needs to be rectified along with this.

Hi @HarshitNagpal29, sorry for replying late, we should submit the change to https://github.com/apache/dolphinscheduler-sdk-python. for more specific line are those lines https://github.com/apache/dolphinscheduler-sdk-python/blob/e04b836e54fb7bfd96527007cfeaa0fef4444b07/src/pydolphinscheduler/examples/tutorial.py#L51-L54 we should pick one of those task and change them as multiple lines shell example

@HarshitNagpal29
Copy link

@zhongjiajie No problem Sir , I have created pull request again in https://github.com/apache/dolphinscheduler-sdk-python as you said, please check it and let me know if I have to make more changes in that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document enhancement New feature or request feature new feature good first issue good first issue help wanted Extra attention is needed Python
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants