Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement of round based function #32755

Closed
4 tasks done
zhiqiang-hhhh opened this issue Mar 25, 2024 Discussed in #32086 · 4 comments
Closed
4 tasks done

Enhancement of round based function #32755

zhiqiang-hhhh opened this issue Mar 25, 2024 Discussed in #32086 · 4 comments

Comments

@zhiqiang-hhhh
Copy link
Contributor

zhiqiang-hhhh commented Mar 25, 2024

Discussed in #32086

We need to make round based functions support using column as its scale argument.

  • Truncate
  • Round
  • Floor
  • Ceil
@zhiqiang-hhhh
Copy link
Contributor Author

truncate: #32746

@superdiaodiao
Copy link
Contributor

May I ask the other three enhancement tasks assigned to anyone? If not, could you assign to me?

@zhiqiang-hhhh
Copy link
Contributor Author

May I ask the other three enhancement tasks assigned to anyone? If not, could you assign to me?

@superdiaodiao thanks for your attention, they are pending, and they are yours.

Just to let you know, the task is not difficult, but need much explore work in mysql.

Specifically, we need to make sure we have same behaviour with mysql, for example, in function truncate, when using literal as scale argument, its behaviour is different from using column as scale argument. I do not test the others in mysql, but I think they may have same problem.

Tips for implementation:

  1. The pression of decimal should not change.
  2. The scale of decimal may depend on the specific situation ( need to be same with mysql)
  3. Need BEUT & regression test
  4. docs update in https://github.com/apache/doris-website

Thanks your attention again, enjoy the process!

@superdiaodiao
Copy link
Contributor

superdiaodiao commented Apr 28, 2024

@superdiaodiao thanks for your attention, they are pending, and they are yours.

Just to let you know, the task is not difficult, but need much explore work in mysql.

Specifically, we need to make sure we have same behaviour with mysql, for example, in function truncate, when using literal as scale argument, its behaviour is different from using column as scale argument. I do not test the others in mysql, but I think they may have same problem.

Tips for implementation:

  1. The pression of decimal should not change.
  2. The scale of decimal may depend on the specific situation ( need to be same with mysql)
  3. Need BEUT & regression test
  4. docs update in https://github.com/apache/doris-website

Thanks your attention again, enjoy the process!

Alright, thank you very much for all these, it means a lot~~~
I will try my best and may need your review in the future PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants