DRILL-7072: Query with semi join fails for JDBC storage plugin

closes #1674
apache · Mar 8, 2019 · 6bd31f3 · 6bd31f3
1 parent 619a499
commit 6bd31f3
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/...torage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestJdbcPluginWithMySQLIT.java b/...torage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestJdbcPluginWithMySQLIT.java
@@ -308,4 +308,19 @@ public void testJoinStar() throws Exception {
         .baselineValues(5, 5)
         .go();
   }
+
+  @Test
+  public void testSemiJoin() throws Exception {
+    String query =
+        "select person_id from mysql.`drill_mysql_test`.person t1\n" +
+            "where exists (" +
+                "select person_id from mysql.`drill_mysql_test`.person\n" +
+                "where t1.person_id = person_id)";
+    testBuilder()
+        .sqlQuery(query)
+        .unOrdered()
+        .baselineColumns("person_id")
+        .baselineValuesForSingleColumn(1, 2, 3, 5)
+        .go();
+  }
 }
diff --git a/exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillSemiJoinRule.java b/exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillSemiJoinRule.java
@@ -41,7 +41,7 @@
 /**
  * Planner rule that creates a {@code DrillSemiJoinRel} from a
  * {@link org.apache.calcite.rel.core.Join} on top of a
- * {@link org.apache.calcite.rel.logical.LogicalAggregate}.
+ * {@link org.apache.calcite.rel.core.Aggregate}.
  */
 public abstract class DrillSemiJoinRule extends RelOptRule {
   private static final Predicate<Join> IS_LEFT_OR_INNER =
@@ -168,7 +168,7 @@ private static boolean isSimpleJoinCondition(RexNode joinCondition) {
   @Override
   public boolean matches(RelOptRuleCall call) {
     Join join = call.rel(0);
-    DrillAggregateRel agg = call.rel(2);
+    Aggregate agg = call.rel(2);
     if (agg.getAggCallList().size() != 0) { return false; }
     return  isSimpleJoinCondition(join.getCondition()) &&
             isRowTypeSame(join, call.rel(1), call.rel(2).getInput(0));