Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespaced Query Time Lookups might not handle drivers correctly #2345

Closed
drcrallen opened this issue Jan 27, 2016 · 4 comments
Closed

Namespaced Query Time Lookups might not handle drivers correctly #2345

drcrallen opened this issue Jan 27, 2016 · 4 comments

Comments

@drcrallen
Copy link
Contributor

As per https://groups.google.com/d/msg/druid-user/3Iqi6yYG5pA/MmWDZW0BBAAJ there might be a problem in the JDBCExtractionNamespaceFunctionFactory whereby the JDBC driver is not registered with the DBI. It is notable that MySQLConnector and PostgreSQLConnector have explicit registering of the driver in part of the constructor.

A few issues arise here:

  1. The classloaders for the connector extensions are isolated from the namespaced lookup extension, this means that even if the proper registering were enforced, it is not guaranteed that the namespaced lookup extension would be using the registration from the mysql (or postgress) extension.
  2. The connectors probably need more abstraction to allow non-metadata stuff to utilize them.
  3. The JDBCExtractionNamespaceFunctionFactory would need a way to either A) pull from a extension config (assuming all lookups will use the same JDBC URI), or B) have a means to plug into an extension's JDBC driver registry so that different instances of namespaces can load up their drivers properly.
  4. ClassLoader and JDBC driver dependencies are notoriously difficult to catch in unit tests.
@MdeArcayne
Copy link

So #2819 does not fix this yet? So far Its been impossible for me to use a JDBC lookup, same reason as the original group post. Has anyone succeeded in using them?

@b-slim
Copy link
Contributor

b-slim commented Oct 1, 2016

Sorry @MdeArcayne #2819 will have the same driver issue.

@github-actions
Copy link

This issue has been marked as stale due to 280 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If this issue is still
relevant, please simply write any comment. Even if closed, you can still revive the
issue at any time or discuss it on the dev@druid.apache.org list.
Thank you for your contributions.

@github-actions github-actions bot added the stale label May 30, 2023
@github-actions
Copy link

This issue has been closed due to lack of activity. If you think that
is incorrect, or the issue requires additional review, you can revive the issue at
any time.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants