Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent null/empty str handling for multi-value/single-value dimensions in QueryableIndexStorageAdapter #2776

Closed
jon-wei opened this issue Apr 1, 2016 · 3 comments
Labels
Milestone

Comments

@jon-wei
Copy link
Contributor

jon-wei commented Apr 1, 2016

In the Cursor returned by QueryableIndexStorageAdapter, the DimensionSelectors created from the Cursor have different null handling behavior for multi-value and single-value dimensions.

In the implementation of DimensionSelector.lookupName(id):

  • For multi-value dimensions, Strings.nullToEmpty() is called on the value before it is returned or passed to the extractionFn.
  • For single-value dimensions, there is no null->empty str conversion.

DimensionSelectors originating from an IncrementalIndex do not perform the null->empty str conversion either.

@xvrl
Copy link
Member

xvrl commented Apr 2, 2016

@jon-wei @gianm can we put together a larger issue to aggregate all the null issues you've been seeing lately? It might make sense to have a more comprehensive view of all the issues to help figure out what needs to be done.

@jon-wei
Copy link
Contributor Author

jon-wei commented Apr 2, 2016

@xvrl I've opened an issue here: #2778

@jon-wei
Copy link
Contributor Author

jon-wei commented Apr 11, 2016

Fixed in #2690

@jon-wei jon-wei closed this as completed Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants