Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to AWS S3 SDK #4289

Closed
niketh opened this issue May 17, 2017 · 11 comments
Closed

Move to AWS S3 SDK #4289

niketh opened this issue May 17, 2017 · 11 comments

Comments

@niketh
Copy link
Contributor

niketh commented May 17, 2017

I plan to move to using AWS S3 SDK instead of using JetS3T. I have noticed the following problems with JetS3T:

  1. AWS SDK has better support for auth (reading credentials files etc)
  2. It is far behind AWS S3 SDK in terms of development-release/support.

What do you think @gianm @leventov @cheddar ?

@gianm
Copy link
Contributor

gianm commented May 17, 2017

+1, aws-java-sdk seems better than jets3t these days. Related: #4116 which would add support for s3a (aws-java-sdk backed S3) to Hadoop indexing.

@drcrallen
Copy link
Contributor

There are some in the community who use jets3t.properties, so such a change would either need a migration plan or a major version update

@gianm
Copy link
Contributor

gianm commented May 17, 2017

My feeling is it's not worth supporting both at the same time, and instead we should do it in 0.11.0 and tell people that jets3t properties will no longer be respected (but whatever new aws-java-sdk configurator thing will).

@drcrallen
Copy link
Contributor

@gianm agreed. also it wasn't clear in my prior message, but I think moving to the AWS sdk is a great idea.

@leventov
Copy link
Member

Duplicate of #3886

@leventov
Copy link
Member

Labelling Incompatible and Release Notes because present users may have jets3t.properties file to change some s3 configurations, that will stop working silently when code is changed to use official SDK.

@drcrallen
Copy link
Contributor

@leventov is the solution for this one going to have to have a config that creates a https://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/index.html?com/amazonaws/ClientConfiguration.html , or do you know of a way to have a jets3t.properties kind of file on the classpath?

@leventov
Copy link
Member

@drcrallen I don't know, but creating a config via "Druid native" properties sounds like a good solution, for unification.

@leventov
Copy link
Member

leventov commented Jun 7, 2017

Related #4382

@jihoonson
Copy link
Contributor

I'm working on this.

@jihoonson jihoonson self-assigned this Dec 7, 2017
@sjtoik
Copy link

sjtoik commented Dec 13, 2017

Cool! The endpoint configuration should be trivial with the new AWSClient-builder thingy. That just needs to be propagated trough-out the stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants