Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segment filtering should be done by looking at the inner most query of a nested query #5493

Closed
samarthjain opened this issue Mar 15, 2018 · 7 comments
Closed

Segment filtering should be done by looking at the inner most query of a nested query #5493

samarthjain opened this issue Mar 15, 2018 · 7 comments

Comments

@samarthjain
Copy link
Contributor

No description provided.

@samarthjain
Copy link
Contributor Author

5493.txt

Patch file with fix and test case attached.

@samarthjain
Copy link
Contributor Author

@jihoonson, @gianm - as part of working on #5471, I discovered this issue with nested queries. When you get a chance, can you please take a look? Thanks!

@jihoonson
Copy link
Contributor

@samarthjain is the attached patch is for #5471? If so, you can simply push more commits to your repository. It will be reflected automatically to your PR.

@samarthjain
Copy link
Contributor Author

@jihoonson, the patch is not related to 5471. It looks like a bug in general.

@jihoonson
Copy link
Contributor

@samarthjain oh nice! Then, would you make another PR for this issue? It would be much better to review your work.

@samarthjain
Copy link
Contributor Author

Created #5496

@jihoonson
Copy link
Contributor

Close via #5496.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samarthjain @jihoonson