You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
DimFilter has a lot of repeated code between different implementations due to everything having an extractionFn and soon, a filterTuning following #8209. See this comment, and this is semi-related to #8242 in that it is suggesting a path to remove extractionFn from DimFilter so coordination is probably required.
Additionally, I think DimFilter and Filter can be combined, I understand they exist as separate entities so that DimFilter could be a light-weight 'client' object that was unaware of selectors and such, but this doesn't seem necessary with the current design of things and there is a lot of redundant stuff going on here that could be improved.
Finally, there is some room for improvements in how tests are creating DimFilters, so static methods to create filters for testing so passing in null for extractionFn and filterTuning should be added to decouple tests from the json schema of filters.
The text was updated successfully, but these errors were encountered:
Description
DimFilter
has a lot of repeated code between different implementations due to everything having anextractionFn
and soon, afilterTuning
following #8209. See this comment, and this is semi-related to #8242 in that it is suggesting a path to removeextractionFn
fromDimFilter
so coordination is probably required.Additionally, I think
DimFilter
andFilter
can be combined, I understand they exist as separate entities so thatDimFilter
could be a light-weight 'client' object that was unaware of selectors and such, but this doesn't seem necessary with the current design of things and there is a lot of redundant stuff going on here that could be improved.Finally, there is some room for improvements in how tests are creating
DimFilters
, so static methods to create filters for testing so passing innull
forextractionFn
andfilterTuning
should be added to decouple tests from the json schema of filters.The text was updated successfully, but these errors were encountered: