Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor filters #8256

Open
clintropolis opened this issue Aug 7, 2019 · 0 comments
Open

refactor filters #8256

clintropolis opened this issue Aug 7, 2019 · 0 comments

Comments

@clintropolis
Copy link
Member

Description

DimFilter has a lot of repeated code between different implementations due to everything having an extractionFn and soon, a filterTuning following #8209. See this comment, and this is semi-related to #8242 in that it is suggesting a path to remove extractionFn from DimFilter so coordination is probably required.

Additionally, I think DimFilter and Filter can be combined, I understand they exist as separate entities so that DimFilter could be a light-weight 'client' object that was unaware of selectors and such, but this doesn't seem necessary with the current design of things and there is a lot of redundant stuff going on here that could be improved.

Finally, there is some room for improvements in how tests are creating DimFilters, so static methods to create filters for testing so passing in null for extractionFn and filterTuning should be added to decouple tests from the json schema of filters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant