Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken master because of duplicate injection #9002

Closed
jihoonson opened this issue Dec 9, 2019 · 1 comment · Fixed by #9005
Closed

Broken master because of duplicate injection #9002

jihoonson opened this issue Dec 9, 2019 · 1 comment · Fixed by #9005
Labels
Milestone

Comments

@jihoonson
Copy link
Contributor

Affected Version

Current master

Description

Here is the error on start up. Maybe it only happens with coordinator + overlord mode.

1) A binding to org.apache.druid.discovery.NodeRole annotated with interface org.apache.druid.guice.annotations.Self was already configured at org.apache.druid.cli.CliCoordinator$1.configure(CliCoordinator.java:242) (via modules: com.google.inject.util.Modules$Override
Module -> com.google.inject.util.Modules$OverrideModule -> org.apache.druid.cli.CliCoordinator$1).
  at org.apache.druid.cli.CliOverlord$1.configure(CliOverlord.java:251) (via modules: com.google.inject.util.Modules$OverrideModule -> com.google.inject.util.Modules$OverrideModule -> org.apache.druid.cli.CliOverlord$1)

1 error
        at org.apache.druid.cli.GuiceRunnable.makeInjector(GuiceRunnable.java:72)
        at org.apache.druid.cli.ServerRunnable.run(ServerRunnable.java:56)
        at org.apache.druid.cli.Main.main(Main.java:113)
Caused by: com.google.inject.CreationException: Unable to create injector, see the following errors:

1) A binding to org.apache.druid.discovery.NodeRole annotated with interface org.apache.druid.guice.annotations.Self was already configured at org.apache.druid.cli.CliCoordinator$1.configure(CliCoordinator.java:242) (via modules: com.google.inject.util.Modules$Override
Module -> com.google.inject.util.Modules$OverrideModule -> org.apache.druid.cli.CliCoordinator$1).
  at org.apache.druid.cli.CliOverlord$1.configure(CliOverlord.java:251) (via modules: com.google.inject.util.Modules$OverrideModule -> com.google.inject.util.Modules$OverrideModule -> org.apache.druid.cli.CliOverlord$1)

1 error
        at com.google.inject.internal.Errors.throwCreationExceptionIfErrorsExist(Errors.java:470)
        at com.google.inject.internal.InternalInjectorCreator.initializeStatically(InternalInjectorCreator.java:155)
        at com.google.inject.internal.InternalInjectorCreator.build(InternalInjectorCreator.java:107)
        at com.google.inject.Guice.createInjector(Guice.java:99)
        at com.google.inject.Guice.createInjector(Guice.java:73)
        at com.google.inject.Guice.createInjector(Guice.java:62)
        at org.apache.druid.initialization.Initialization.makeInjectorWithModules(Initialization.java:431)
        at org.apache.druid.cli.GuiceRunnable.makeInjector(GuiceRunnable.java:69)
        ... 2 more
@jihoonson jihoonson added the Bug label Dec 9, 2019
@jihoonson jihoonson added this to the 0.17.0 milestone Dec 9, 2019
@jihoonson
Copy link
Contributor Author

Looks like this was caused by https://github.com/apache/incubator-druid/pull/6702/files#diff-8306af8ad09532617fa5a47941bc81b8R242. Should it be the multibinding?

@jihoonson jihoonson mentioned this issue Dec 9, 2019
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant