Feature: Add IPv6 Match Function #15212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
processing/src/main/java/org/apache/druid/query/expression/IPv6AddressMatchExprMacro.java
Fixed
Show resolved
Hide resolved
|
Hi - is there an approx ETA for a release containing this change? |
It will depend when this PR gets reviewed. I've been keeping an eye on it but unfortunately I don't have any way of asking maintainers to have a look. Doesn't look like this will get in prior to the 28.0 milestone but hopefully it will be in the one afterwards (reviews dependent!) |
|
@LakshSingla, @abhishekagarwal87 Sorry to bother you both but would it be possible to get a PR review on this please? Just been open a while and I would welcome your feedback! |
clintropolis
reviewed
Dec 5, 2023
processing/src/main/java/org/apache/druid/query/expression/IPv6AddressMatchExprMacro.java
Outdated
Show resolved
Hide resolved
...java/org/apache/druid/sql/calcite/expression/builtin/IPv6AddressMatchOperatorConversion.java
Outdated
Show resolved
Hide resolved
|
Made suggested changes, ready for another review :) |
clintropolis
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10817.
Description
Added a SQL function to match IPv6 addresses to a given subnet. This was based off the existing
IPv4_MATCHfunction. I initially considered changing the existingIPv4_MATCHfunction to be a more generic (e.g.IP_MATCH). However, given this has been a function for some time I thought it best to keep the existing function for existing queries and make an IPv6 specific implementation. Like the existing IPv4 implementation, this relies on the Javainet.ipaddrlibraryRelease note
Added
IPv6_MATCHSQL function for matching IPv6 addresses in a subnetKey added classes in this PR
IPv6AddressExprUtilsIPv6AddressMatchExprMacroThis PR has: