Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DubboGrpcGenerator output java code not format. #12296

Open
2 tasks done
win5do opened this issue May 11, 2023 · 1 comment
Open
2 tasks done

DubboGrpcGenerator output java code not format. #12296

win5do opened this issue May 11, 2023 · 1 comment
Labels
type/proposal Everything you want Dubbo have

Comments

@win5do
Copy link

win5do commented May 11, 2023

  • I have searched the issues of this repository and believe that this is not a duplicate.
  • I have searched the release notes of this repository and believe that this is not a duplicate.

Describe the feature

image
image

        <dubbo.version>2.7.7</dubbo.version>
        <dubbo.compiler.version>3.1.10</dubbo.compiler.version>
        <spring.version>4.3.16.RELEASE</spring.version>
        <grpc.version>1.34.1</grpc.version>
        <protoc.version>3.21.9</protoc.version>
        <protoc.third_party>./</protoc.third_party>
        <protobuff-java.version>3.21.9</protobuff-java.version>


            <plugin>
                <groupId>org.xolstice.maven.plugins</groupId>
                <artifactId>protobuf-maven-plugin</artifactId>
                <version>0.6.1</version>
                <configuration>
                    <protocArtifact>com.google.protobuf:protoc:${protoc.version}:exe:${os.detected.classifier}
                    </protocArtifact>
                    <pluginId>grpc-java</pluginId>
                    <pluginArtifact>io.grpc:protoc-gen-grpc-java:${grpc.version}:exe:${os.detected.classifier}
                    </pluginArtifact>
                    <outputDirectory>build/generated/source/proto/main/java</outputDirectory>
                    <clearOutputDirectory>false</clearOutputDirectory>
                    <protocPlugins>
                        <protocPlugin>
                            <id>dubbo-grpc</id>
                            <groupId>org.apache.dubbo</groupId>
                            <artifactId>dubbo-compiler</artifactId>
                            <version>${dubbo.compiler.version}</version>
                            <mainClass>org.apache.dubbo.gen.grpc.DubboGrpcGenerator</mainClass>
                        </protocPlugin>
                    </protocPlugins>
                    <additionalProtoPathElements>
                        <additionalProtoPathElement>${protoc.third_party}</additionalProtoPathElement>
                    </additionalProtoPathElements>
                </configuration>
                <executions>
                    <execution>
                        <goals>
                            <goal>compile</goal>
                            <goal>compile-custom</goal>
                            <goal>test-compile</goal>
                            <goal>test-compile-custom</goal>
                        </goals>
                    </execution>
                </executions>
            </plugin>

The java code format is confusing, can it be formatted and then generated?

@win5do win5do mentioned this issue May 13, 2023
8 tasks
@AlbumenJ
Copy link
Member

Will be fixed in #12297

@AlbumenJ AlbumenJ added type/proposal Everything you want Dubbo have and removed type/feature labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/proposal Everything you want Dubbo have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants