Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The dubbo-registry-nacos module does not release nacos resources during dubbo shutdown. #13286

Closed
caoyanan666 opened this issue Oct 30, 2023 · 1 comment
Labels
type/bug Bugs to being fixed

Comments

@caoyanan666
Copy link
Contributor

Details can be found in alibaba/nacos#11294

org.apache.dubbo.registry.nacos.NacosRegistry needs to release the nacos service when it is destroyed

package org.apache.dubbo.registry.nacos;


public class NacosRegistry extends FailbackRegistry {
    ...
    @Override
    public void destroy() {
        super.destroy();
        try {
            this.namingService.shutdown();
        } catch (Throwable ignored) {
            logger.warn(ignored.getMessage(), ignored);
        }
        logger.info("nacos registry shutdown");
    }
}
@AlbumenJ
Copy link
Member

AlbumenJ commented Nov 1, 2023

Duplicated with #10834. Please upgrade to the latest version. 3.0.x is EOL now.

@AlbumenJ AlbumenJ closed this as completed Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Bugs to being fixed
Projects
None yet
Development

No branches or pull requests

2 participants