Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Move Mesh Rule Router to SPI Extensions #13957

Closed
3 of 4 tasks
AlbumenJ opened this issue Mar 20, 2024 · 11 comments
Closed
3 of 4 tasks

[Feature] Move Mesh Rule Router to SPI Extensions #13957

AlbumenJ opened this issue Mar 20, 2024 · 11 comments
Assignees
@heliang666s
Labels
component/sdk Related with apache/dubbo component/spi-extensions Related with apache/dubbo-spi-extensions good first issue Good for starters to contribute help wanted Everything needs help from contributors type/enhancement Everything related with code enhancement or performance

Comments

@AlbumenJ
Copy link
Member

Pre-check

  • I am sure that all the content I provide is in English.

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Apache Dubbo Component

Java SDK (apache/dubbo)

Descriptions

Move Mesh Rule Router(dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/router/mesh) to SPI Extensions

Related issues

No response

Are you willing to submit a pull request to fix on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct
@AlbumenJ AlbumenJ added type/need-triage Need maintainers to triage component/need-triage Need maintainers to triage help wanted Everything needs help from contributors type/enhancement Everything related with code enhancement or performance good first issue Good for starters to contribute component/sdk Related with apache/dubbo component/spi-extensions Related with apache/dubbo-spi-extensions and removed type/need-triage Need maintainers to triage component/need-triage Need maintainers to triage labels Mar 20, 2024
@heliang666s
Copy link
Contributor

hello,I want to solve it,please assign it to me,thanks ~

@AlbumenJ
Copy link
Member Author

hello,I want to solve it,please assign it to me,thanks ~

done

@heliang666s
Copy link
Contributor

图片
hi,I don't know how to implement the interface,can you give some details or advice,thanks

@AlbumenJ
Copy link
Member Author

AlbumenJ commented Apr 2, 2024

Just copy all the related code to dubbo-spi-extensions and then remove them in apache/dubbo

@heliang666s
Copy link
Contributor

PTAL @AlbumenJ apache/dubbo-spi-extensions#307

@heliang666s heliang666s mentioned this issue Apr 8, 2024
Closed
8 tasks
@heliang666s
Copy link
Contributor

@AlbumenJ I remove dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/router/mesh ,but other code depend on the file.How I can solve it?add dependency in pom.xml?
图片

@AlbumenJ
Copy link
Member Author

@AlbumenJ I remove dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/router/mesh ,but other code depend on the file.How I can solve it?add dependency in pom.xml? 图片

How about copy all the related classes to org.apache.dubbo.rpc.cluster.configurator.parser.model

@heliang666s heliang666s mentioned this issue Apr 10, 2024
Closed
8 tasks
@walkinggo
Copy link
Contributor

Is this issue completed? Is there any progress? I am very interested in this and want to join. @heliang666s

1 similar comment
@wcy666103
Copy link
Contributor

Is this issue completed? Is there any progress? I am very interested in this and want to join. @heliang666s

@heliang666s
Copy link
Contributor

This issue is basically done, I've filed it at apache/dubbo-spi-extensions#307 and the merge was successful. I was a bit busy a while ago and had a little problem left in the msater branch, and I'll fix it recently. Thank you for your concern @wcy666103 @walkinggo

@songxiaosheng
Copy link
Member

ref apache/dubbo-spi-extensions#307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heliang666s heliang666s

Labels
component/sdk Related with apache/dubbo component/spi-extensions Related with apache/dubbo-spi-extensions good first issue Good for starters to contribute help wanted Everything needs help from contributors type/enhancement Everything related with code enhancement or performance
Projects
Dubbo Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@AlbumenJ @walkinggo @wcy666103 @songxiaosheng @heliang666s