Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal]Embedded Short-Circuit support #2037

Open
chickenlj opened this issue Jul 6, 2018 · 2 comments
Open

[Proposal]Embedded Short-Circuit support #2037

chickenlj opened this issue Jul 6, 2018 · 2 comments
Assignees
Labels
type/proposal Everything you want Dubbo have
Milestone

Comments

@chickenlj
Copy link
Contributor

Hello, community

I am writing to introduce a proposal of supporting short-circuit in Dubbo. This is a feature that the community desperately needs.

Some discussions about this feature recently:

#1574
#1505
https://lists.apache.org/thread.html/59b8feb5b6c379e9aa081c1a2a39171f10108d4a79901320de2310d8@%3Cdev.dubbo.apache.org%3E

Hystrix

Hystrix provides a quite easy way for developers by wrapping Dubbo RPC calls, and it can be more flexible by using directly, so I think there's no need of integrating ystrix with Dubbo internally. Besides, the Dubbo team has provided a demo of using Hystrix with Dubbo.

Embedded Short-Circuit support

Dubbo has a fallback mechanism, known as mock, but it's not intelligent enough, it will always start a remote call and default to fallback only when this call fails. To make it more intelligent, we can add a decision maker, called Circuit Breaker, based on the statistics collected. The state of the Circuit Breaker changes continuously, so it can be used to decide whether to make an actual remote call or return directly with the fallback value when a request comes.

@ralf0131 has submitted a PR #1966 introducing a totally new Metrics module, I think this module can be used as the basis of the upcoming Circuit Breaker.

Below is the extensions I think we should add:

  • One new LoadBalance policy that can distribute traffic according to downstream node healthy status.
  • One new Cluster policy works as an intelligent mock based on the Circuit Breaker.
@chickenlj
Copy link
Contributor Author

#1923

@aamingaa
Copy link
Contributor

aamingaa commented Jan 6, 2023

I want to try, please assign to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/proposal Everything you want Dubbo have
Projects
Status: Todo
Development

No branches or pull requests

4 participants