Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observation of performance degradation of 2.7.2 when running under JDK 8 #4279

Closed
chickenlj opened this issue Jun 12, 2019 · 0 comments
Closed
Milestone

Comments

@chickenlj
Copy link
Contributor

The above result.get() will eventually delegate to CompletableFuture.get(). I checked the implementation provided in JDK 8, it will first spin-waiting for the countdown of 256 (the eighth power of 2) and then park the thread. I believe it's the unnecessary spin that caused the bad performance.

When running under JDK 11, the performance performs well as the previous versions, I still does not check the difference between these two implementations yet.

Thank @Jeff-Lv for help finding this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants