Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RegistryProtocol.DestroyableExporter 格式优化 #4570

Closed
1 task
sin-ning opened this issue Jul 15, 2019 · 5 comments
Closed
1 task

RegistryProtocol.DestroyableExporter 格式优化 #4570

sin-ning opened this issue Jul 15, 2019 · 5 comments
Assignees
Milestone

Comments

@sin-ning
Copy link

  • I have searched the issues of this repository and believe that this is not a duplicate.
  • [ -] I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

  • Dubbo version: 2.7.3

Steps to reproduce this issue

Expected Result

Actual Result

    // private 应该改为  private static 保持统一
    static private class DestroyableExporter<T> implements Exporter<T> {
          // 省略
    }
@cvictory
Copy link
Contributor

Can you post pull request for this issue?

@AnthonyKot
Copy link
Contributor

Do you mean something like this:
#4583

@sin-ning
Copy link
Author

No.

static private class DestroyableExporter<T> implements Exporter<T> {
}

The following should be changed.

private static class DestroyableExporter<T> implements Exporter<T> {
}

@beiwei30 beiwei30 added this to To do in make code clean via automation Aug 1, 2019
@beiwei30 beiwei30 added this to the some day milestone Aug 1, 2019
@beiwei30
Copy link
Member

beiwei30 commented Aug 1, 2019

@sin-ning would you mind to submit a pull request to enhance it?

@Moriadry-zz
Copy link

This issue has been solved, can be closed now. @beiwei30

make code clean automation moved this from To do to Done Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

5 participants