Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The type 'java.lang.String' in metadata shouldn't include internal type. #4984

Closed
lexburner opened this issue Sep 3, 2019 · 3 comments · Fixed by #5032
Closed

The type 'java.lang.String' in metadata shouldn't include internal type. #4984

lexburner opened this issue Sep 3, 2019 · 3 comments · Fixed by #5032
Assignees

Comments

@lexburner
Copy link
Contributor

lexburner commented Sep 3, 2019

{
    "parameters": {
        "side": "provider",
        "release": "2.7.2-SNAPSHOT",
        "methods": "hi,echo,test1,plus",
        "deprecated": "false",
        "dubbo": "2.0.2",
        "interface": "com.alibaba.dubbo.samples.DemoApi",
        "version": "1.0.0",
        "qos.enable": "false",
        "generic": "false",
        "timeout": "3000",
        "revision": "1.0.0",
        "serialization": "hessian2",
        "application": "demo-provider",
        "dynamic": "true",
        "register": "true",
        "bean.name": "com.alibaba.dubbo.samples.DemoApi",
        "group": "DUBBO",
        "anyhost": "true"
    },
    "canonicalName": "com.alibaba.dubbo.samples.DemoApi",
    "methods": [
        {
            "name": "hi",
            "parameterTypes": [
                "com.alibaba.dubbo.samples.Foo"
            ],
            "returnType": "com.alibaba.dubbo.samples.Foo"
        },
        {
            "name": "test1",
            "parameterTypes": [],
            "returnType": "void"
        },
        {
            "name": "echo",
            "parameterTypes": [
                "java.lang.String"
            ],
            "returnType": "java.lang.String"
        },
        {
            "name": "plus",
            "parameterTypes": [
                "int",
                "int"
            ],
            "returnType": "int"
        }
    ],
    "types": [
        {
            "type": "int"
        },
        {
            "type": "void"
        },
        {
            "type": "char"
        },
        {
            "type": "com.alibaba.dubbo.samples.Foo",
            "properties": {
                "name": {
                    "type": "java.lang.String",
                    "properties": {
                        "value": {
                            "type": "char[]"
                        },
                        "hash": {
                            "type": "int"
                        }
                    }
                },
                "age": {
                    "type": "int"
                }
            }
        },
        {
            "type": "java.lang.String",
            "properties": {
                "value": {
                    "type": "char[]"
                },
                "hash": {
                    "type": "int"
                }
            }
        }
    ]
}

Type of char[] and int in java.lang.String is unnecessary.

@lexburner lexburner assigned lexburner and cvictory and unassigned lexburner Sep 3, 2019
@Moriadry-zz
Copy link

Moriadry-zz commented Sep 6, 2019

@lexburner Then what is the properties of java.lang.String? What about null?

I can help with this issue.

@lexburner
Copy link
Contributor Author

@moriadry Consider 'java.lang.String' as a base type like intdouble. Don't need any properties.

@Moriadry-zz
Copy link

@lexburner I raised a pull request to fix it. Pls feel free to review it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants