Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new feathure Add GZIP support for large message #6485

Open
2 tasks done
johnny2002 opened this issue Jul 17, 2020 · 5 comments
Open
2 tasks done

new feathure Add GZIP support for large message #6485

johnny2002 opened this issue Jul 17, 2020 · 5 comments
Labels
type/proposal Everything you want Dubbo have
Milestone

Comments

@johnny2002
Copy link

johnny2002 commented Jul 17, 2020

  • I have searched the issues of this repository and believe that this is not a duplicate.
  • I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

  • Dubbo version: 2.7.7
  • Operating System version: windows10
  • Java version: 14

We sometimes has very large data to retrieve from dubbo service, in order to reduce the transportation cost, please add a feathure to compress the message.

suggested:

  1. dubbo.protocol.gzip.enabled=true, to enable the compress function.
  2. dubbo.protocol.gzip.payload=1M, messages larger than 1M bytes will be compressed.

Reference:
https://github.com/lshm/dubbo-gzip/blob/master/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/exchange/codec/ExchangeCodec.java

@chickenlj
Copy link
Contributor

It would be great if someone can help to add this support.

One thing to keep in mind, make sure it's optional and extensible.

@chickenlj chickenlj added this to the some day milestone Jul 17, 2020
@chickenlj
Copy link
Contributor

FYI, it's not recommended to transport large data in one TCP connection.

@htynkn
Copy link
Member

htynkn commented Jul 17, 2020

@johnny2002
Copy link
Author

It would be great if someone can help to add this support.

One thing to keep in mind, make sure it's optional and extensible.

I'd like to help, but, how can I help?

@johnny2002
Copy link
Author

johnny2002 commented Jul 17, 2020

I have tested to merge the code from those sample to 2.7.7, and it works. BTW, the original code has some bugs, need to fix.

@CrazyHZM CrazyHZM added the type/proposal Everything you want Dubbo have label Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/proposal Everything you want Dubbo have
Projects
None yet
Development

No branches or pull requests

5 participants