Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System environment variable naming(dubbo.application.logger) #7013

Open
tonycody opened this issue Dec 10, 2020 · 0 comments
Open

System environment variable naming(dubbo.application.logger) #7013

tonycody opened this issue Dec 10, 2020 · 0 comments
Labels
help wanted Everything needs help from contributors type/proposal Everything you want Dubbo have

Comments

@tonycody
Copy link
Contributor

org.apache.dubbo.common.logger.LoggerFactory.java:44

这个类里面,根据系统环境变量的配置,创建指定类型的LoggerAdapter
这里面使用的环境变量的名称,没考虑过不同系统的支持吗?

dubbo.application.logger

这种命名风格的系统环境变量,在类linux下是无法创建成功的,在Windows下是可以的。

建议官方考虑一下使用场景,既然是系统环境变量,就得考虑不同类型系统是否支持。

虽然通过-Ddubbo.application.logger=log4j,在通过java指令执行期也是可以解的,但如果是配置系统环境变量,linux下不好解

@CrazyHZM CrazyHZM added help wanted Everything needs help from contributors type/proposal Everything you want Dubbo have labels Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Everything needs help from contributors type/proposal Everything you want Dubbo have
Projects
None yet
Development

No branches or pull requests

2 participants