Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: endLabel color support 'auto' 'inherit' #14000

Merged
merged 2 commits into from
Jan 28, 2021

Conversation

susiwen8
Copy link
Contributor

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixed issues

Close #13685

Details

Before: What was the problem?

Screen Shot 2021-01-10 at 16 25 47

After: How is it fixed in this PR?

Screen Shot 2021-01-10 at 16 25 33

Usage

Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

test/line-endLabel.html

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jan 10, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@susiwen8 susiwen8 requested review from Ovilia and pissang and removed request for Ovilia January 10, 2021 08:28
@pissang pissang added this to the 5.1.0 milestone Jan 10, 2021
@pissang pissang modified the milestones: 5.1.0, 5.0.2 Jan 26, 2021
src/chart/line/LineView.ts Show resolved Hide resolved
src/chart/line/LineView.ts Show resolved Hide resolved
@pissang pissang merged commit 3bad840 into apache:master Jan 28, 2021
@echarts-bot
Copy link

echarts-bot bot commented Jan 28, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@susiwen8 susiwen8 deleted the endlabel-color-inherit branch January 28, 2021 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

endLabel do not support color: 'auto' 'inherit'
2 participants