fix(timeline): trigger timelineplaychange event when play to the end #14620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! The pull request is marked to be |
Ovilia
commented
Apr 8, 2021
| api.dispatchAction({ | ||
| type: 'timelinePlayChange', | ||
| playState: false, | ||
| from: payload.from |
There was a problem hiding this comment.
Should from be payload.from or null? The reason to use null is that play ending doesn't come directly from the view (button clicking).
There was a problem hiding this comment.
payload.from indicates the component fires this action. I think we can keep using payload.from here.
pissang
approved these changes
May 12, 2021
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
timelinePlayChangedevent is fired when timeline paused, so it should be fired when play to the end when not looping.This PR makes it fires this event.
Fixed issues
#14588
Details
Before: What was the problem?
When
loopisfalseand timeline plays to the end, no event is fired.After: How is it fixed in this PR?
When
loopisfalseand timeline plays to the end,timelinePlayChangedevent is fired.Usage
Are there any API changes?
Related test cases or examples to use the new APIs
NA.
Others
Merging options
Other information