Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable pointer's z-level adjustment in gauge chart & set default z-le… #15337

Merged
merged 1 commit into from
Jul 13, 2021
Merged

enable pointer's z-level adjustment in gauge chart & set default z-le… #15337

merged 1 commit into from
Jul 13, 2021

Conversation

AmosChenYQ
Copy link
Contributor

@AmosChenYQ AmosChenYQ commented Jul 13, 2021

…vel above detail and title

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Add a 'showAbove' style to pointer of gauge chart to control whether pointer shows above detail and title item.

Fixed issues

Details

Before: What was the problem?

After #15326, default z-level is default under detail and title item and can not change. During cases like car speed dashboard, pointer needs to be above speed number instead of above it.

After: How is it fixed in this PR?

Add a 'showAbove' style to pointer of gauge chart to control whether pointer shows above detail and title item.

image1
image2

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jul 13, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@echarts-bot echarts-bot bot added the PR: awaiting doc Document changes is required for this PR. label Jul 13, 2021
@pissang pissang added this to the 5.2 milestone Jul 13, 2021
@pissang
Copy link
Contributor

pissang commented Jul 13, 2021

Indeed it will be more flexible to be configurable. Nice work!

@pissang pissang merged commit eaf1ee4 into apache:master Jul 13, 2021
@echarts-bot
Copy link

echarts-bot bot commented Jul 13, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@susiwen8
Copy link
Contributor

@AmosChenYQ Please also add documentation in echarts-doc, since showAbove is a new feature

@AmosChenYQ
Copy link
Contributor Author

@AmosChenYQ Please also add documentation in echarts-doc, since showAbove is a new feature

apache/echarts-doc#189 plz review

@plainheart plainheart removed the PR: awaiting doc Document changes is required for this PR. label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants