Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radar): name being - in tooltip when name.show is false #15915 #15985

Merged
merged 5 commits into from
Jan 13, 2022

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Nov 1, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Radar indicator names were displayed in the tooltip as "-" when indicator.name.show is set to be false.

Fixed issues

Details

Before: What was the problem?

Radar indicator names were displayed in the tooltip as "-" when indicator.name.show is set to be false.

image

After: How is it fixed in this PR?

Radar indicator name should be displayed in the tooltip.

image

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Nov 1, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang pissang merged commit 6b78d5a into master Jan 13, 2022
@pissang pissang deleted the fix-15915 branch January 13, 2022 03:28
@echarts-bot
Copy link

echarts-bot bot commented Jan 13, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip shows '-' for labels if radar.name.show = false
3 participants