Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): fix tooltip lag issue when transition is disabled. (#16101) #16212

Merged
merged 2 commits into from
Dec 14, 2021

Conversation

plainheart
Copy link
Member

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix tooltip lag issue when transition is disabled, resolves #16101.

Fixed issues

Details

Before: What was the problem?

We throttled the updatePosition function of tooltip in #15683 to solve the shake and lag issue(raised by #14965) in Chrome(with DevTools open) and Firefox. But as #16101 described, the tooltip will be laggy because of the 50ms interval when transitionDuration is 0.

Refer to #16101, #16091 for more details.

After: How is it fixed in this PR?

Throttle it only when transition is enabled.

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

Please refer to test/tooltip-lag-glitch.html.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Dec 11, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang pissang added this to the 5.3 milestone Dec 14, 2021
@pissang pissang merged commit f670da7 into next Dec 14, 2021
@echarts-bot
Copy link

echarts-bot bot commented Dec 14, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang deleted the fix-tooltip-lag branch December 14, 2021 05:25
@plainheart plainheart linked an issue Dec 14, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip position throttle makes tooltip feel laggy
2 participants