Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(marker): marker state not restore after blur #16670

Merged
merged 6 commits into from
Mar 15, 2022
Merged

fix(marker): marker state not restore after blur #16670

merged 6 commits into from
Mar 15, 2022

Conversation

susiwen8
Copy link
Contributor

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Set component's blur state to true when compoonent is blured

Fixed issues

Details

Before: What was the problem?

Kapture 2022-03-12 at 16 23 20

After: How is it fixed in this PR?

Kapture 2022-03-12 at 16 20 27

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Mar 12, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@susiwen8 susiwen8 requested a review from pissang March 12, 2022 08:29
pissang
pissang reviewed Mar 12, 2022
View reviewed changes
src/util/states.ts Outdated Show resolved Hide resolved
@susiwen8 susiwen8 requested a review from pissang March 12, 2022 15:05
pissang
pissang reviewed Mar 14, 2022
View reviewed changes
src/util/states.ts Outdated Show resolved Hide resolved
src/util/states.ts Outdated Show resolved Hide resolved
@susiwen8 susiwen8 requested a review from pissang March 14, 2022 12:49
pissang
pissang reviewed Mar 15, 2022
View reviewed changes
src/util/states.ts Outdated Show resolved Hide resolved
pissang
pissang reviewed Mar 15, 2022
View reviewed changes
src/util/states.ts Outdated Show resolved Hide resolved
@susiwen8 susiwen8 requested a review from pissang March 15, 2022 02:55
pissang
pissang reviewed Mar 15, 2022
View reviewed changes
src/util/states.ts Outdated Show resolved Hide resolved
@pissang pissang added this to the 5.3.2 milestone Mar 15, 2022
@susiwen8 susiwen8 requested a review from pissang March 15, 2022 05:56
@susiwen8 susiwen8 changed the title fix(state): comp isBlured is true when blur fix(marker): marker state not restore after blur Mar 15, 2022
@pissang pissang merged commit 1016d44 into apache:master Mar 15, 2022
@echarts-bot
Copy link

echarts-bot bot commented Mar 15, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@susiwen8 susiwen8 deleted the 16665 branch March 15, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pissang pissang pissang approved these changes

Assignees
No one assigned
Labels
PR: author is committer size/M
Projects
None yet
Milestone
5.3.2
Development

Successfully merging this pull request may close these issues.

[Bug] type='line'中的emphasis.focus触发后不能正确恢复状态
2 participants
@susiwen8 @pissang