Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(visualmap): add textShadowColor, make text shadow work on visualMap. close #14440 #16679

Merged
merged 4 commits into from
Mar 17, 2022
Merged

fix(visualmap): add textShadowColor, make text shadow work on visualMap. close #14440 #16679

merged 4 commits into from
Mar 17, 2022

Conversation

fuchunhui
Copy link
Contributor

@fuchunhui fuchunhui commented Mar 14, 2022 •
edited by plainheart
Loading

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix a bug that some text styles are not working on visualMap.

Fixed issues

Details

visualMap-continuous

Before After
image image

visualMap-piecewise

Before After
image image

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

  • test/visualMap-continuous.html
  • test/visualMap-pieces.html

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Mar 14, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 14, 2022
Ovilia
Ovilia requested changes Mar 14, 2022
View reviewed changes
src/component/visualMap/ContinuousView.ts Outdated Show resolved Hide resolved
src/model/mixin/textStyle.ts Outdated Show resolved Hide resolved
plainheart
plainheart previously approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@plainheart plainheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

plainheart
plainheart reviewed Mar 14, 2022
View reviewed changes
Copy link
Member

@plainheart plainheart left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more question,
Should we also apply the text style on handleLabel and indicatorLabel?

@plainheart plainheart linked an issue Mar 14, 2022 that may be closed by this pull request
Text shadow is not working on visualMap #14440
Closed
Ovilia
Ovilia previously approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuchunhui
Copy link
Contributor Author

@plainheart Your editing is great, more smarter.

@pissang
Copy link
Contributor

pissang commented Mar 15, 2022 •
edited
Loading

Should we also apply the text style on handleLabel and indicatorLabel?

@fuchunhui So are we planning to add this in this PR as @plainheart suggested?

@fuchunhui fuchunhui dismissed stale reviews from Ovilia and plainheart via a255fa1 March 15, 2022 02:47
@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 15, 2022
@pissang pissang added this to the 5.3.2 milestone Mar 15, 2022
plainheart
plainheart approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@plainheart plainheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pissang pissang merged commit 7bf453a into apache:master Mar 17, 2022
@echarts-bot
Copy link

echarts-bot bot commented Mar 17, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@fuchunhui fuchunhui deleted the fix-14440 branch March 17, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pissang pissang pissang approved these changes

@plainheart plainheart plainheart approved these changes

@Ovilia Ovilia Ovilia left review comments

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
5.3.2
Development

Successfully merging this pull request may close these issues.

Text shadow is not working on visualMap
4 participants
@fuchunhui @pissang @Ovilia @plainheart