Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphic): fix some options may be unexpectedly reset on update #17007

Merged
merged 1 commit into from
May 16, 2022

Conversation

plainheart
Copy link
Member

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

  1. fix that some options may be unexpectedly reset on update
  2. fix that the children of a group element can't be updated when calling setOption with no type: 'group' option.
  3. add a VRT for fix(graphic): fix cursor doesn't work in graphic component. #16513

Fixed issues

N.A.

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

Please refer to test/graphic-cases.html

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

1) fix some options may be unexpectedly reset when calling setOption.
2) fix group children can't be updated when calling setOption with no `type` option.
@echarts-bot
Copy link

echarts-bot bot commented May 11, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@plainheart plainheart merged commit 5cf53e2 into master May 16, 2022
@plainheart plainheart deleted the fix/graphic branch May 16, 2022 03:39
@echarts-bot
Copy link

echarts-bot bot commented May 16, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants