Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(time): Quarters split the year into 4 quarters not 3. close #17057 #17073

Merged
merged 2 commits into from
May 20, 2022
Merged

fix(time): Quarters split the year into 4 quarters not 3. close #17057 #17073

merged 2 commits into from
May 20, 2022

Conversation

Woonters
Copy link
Contributor

@Woonters Woonters commented May 19, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

The quarter format would only go up to Q3 with each quarter having 3 months in them (not the current 4)

Fixed issues

Details

Before: What was the problem?

{q} would return 1 for Jan, Feb, Mar, Apr, 2 for May, Jun, July, Aug, 3 for Sep, Oct, Nov, Dec

After: How is it fixed in this PR?

{q} will return 1 for Jan, Feb, Mar, 2 for Apr, May, Jun, 3 for July, Aug, Sep, 4 for Oct, Nov, Dec

Misc

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented May 19, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@susiwen8
Copy link
Contributor

Could you remove unnecessary binary file?

@plainheart plainheart added this to the 5.3.3 milestone May 19, 2022
Copy link
Member

@plainheart plainheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plainheart plainheart requested a review from Ovilia May 19, 2022 21:36
@Ovilia Ovilia merged commit 6ee5f70 into apache:master May 20, 2022
@echarts-bot
Copy link

echarts-bot bot commented May 20, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Quarter in date format returns only up to Quarter 3
4 participants