Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(geo): fix dataToPoint may not be working in lineGL series. #17150

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

plainheart
Copy link
Member

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix dataToPoint may not be working in lineGL series - add back two missing arguments to projectedToPoint called in Geo dataToPoint function.

Fixed issues

Details

Before: What was the problem?

The example lineGL-ny can't work since v5.3.0 - All lines collapse to the left top corner.

image

After: How is it fixed in this PR?

Add back two missing arguments to projectedToPoint called in Geo dataToPoint function.

image

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

Please refer to test/linesGL-ny-appendData.html

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Related PR: #16364

@plainheart plainheart requested a review from pissang June 3, 2022 03:09
@echarts-bot
Copy link

echarts-bot bot commented Jun 3, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang pissang added this to the 5.3.3 milestone Jun 3, 2022
@pissang pissang merged commit 7a8808d into master Jun 3, 2022
@echarts-bot
Copy link

echarts-bot bot commented Jun 3, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart deleted the fix/geo branch June 3, 2022 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] lineGL-ny can't work since v5.3.0
2 participants