Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(type): export ECElementEvent for TypeScript #17892

Merged

Conversation

keita-determined
Copy link
Contributor

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Export ECElementEvent for Typescript

Fixed issues

#17888

Details

Before: What was the problem?

Couldn't export ECElementEvent

After: How does it behave after the fixing?

ECElementEvent should be exportable by import { ECElementEvent } from "echarts";

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Nov 9, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@plainheart plainheart linked an issue Nov 9, 2022 that may be closed by this pull request
@plainheart plainheart changed the title chore: export ECElementEvent for Typescript feat(type): export ECElementEvent for TypeScript Nov 9, 2022
@plainheart plainheart added this to the 5.4.1 milestone Nov 9, 2022
Copy link
Member

@plainheart plainheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

@plainheart plainheart merged commit 3d69d6c into apache:master Nov 9, 2022
@echarts-bot
Copy link

echarts-bot bot commented Nov 9, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] ECElementEvent is not exportable for Typescript
2 participants