Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssr): fix label doesn't show in line series when ssr is enabled #18032

Merged
merged 1 commit into from
Dec 20, 2022
Merged

fix(ssr): fix label doesn't show in line series when ssr is enabled #18032

merged 1 commit into from
Dec 20, 2022

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented Dec 7, 2022 •
edited
Loading

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

  1. Fix label doesn't show and line path doesn't update correctly in the line series when ssr is enabled.
  2. Fix a typo: seriesDalay -> seriesDelay

Fixed issues

Comparison

Before After
image image
image image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Dec 7, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.

@plainheart plainheart added this to the 5.5.0 milestone Dec 7, 2022
@plainheart plainheart linked an issue Dec 7, 2022 that may be closed by this pull request
[Bug] new SVG renderer fails to render labels on line charts #18027
Closed
pissang
pissang reviewed Dec 8, 2022
View reviewed changes
src/chart/line/LineView.ts
@@ -644,7 +644,7 @@ class LineView extends ChartView {

const lineGroup = this._lineGroup;

const hasAnimation = seriesModel.get('animation');
const hasAnimation = !ecModel.ssr && seriesModel.isAnimationEnabled();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seriesModel.isAnimationEnabled should have considerd ecModel.ssr

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it requires env.node. https://github.com/apache/echarts/blob/master/src/model/Series.ts#L469

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understand, we tried to fix the issue by disabling the animation in SSR mode.

@pissang pissang merged commit d6ab9d4 into master Dec 20, 2022
@echarts-bot
Copy link

echarts-bot bot commented Dec 20, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang deleted the fix-ssr-line branch December 20, 2022 11:13
@Ovilia Ovilia modified the milestones: 5.5.0, 5.4.2 Mar 3, 2023
plainheart added a commit that referenced this pull request Aug 4, 2023
@plainheart
fix(line): fix line may cross when animation is enabled. (brought by #…
7d02d5c 
…18032)
@plainheart plainheart mentioned this pull request Aug 4, 2023
Merged
8 tasks
@X-oss-byte X-oss-byte mentioned this pull request May 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pissang pissang pissang approved these changes

Assignees
No one assigned
Labels
PR: author is committer PR: doc unchanged size/S
Projects
None yet
Milestone
5.4.2
Development

Successfully merging this pull request may close these issues.

[Bug] new SVG renderer fails to render labels on line charts
3 participants
@plainheart @pissang @Ovilia