Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): fix the abbr of "March" for the DE language ("Mar" -> "Mrz") #18387

Merged
merged 1 commit into from Mar 15, 2023

Conversation

Stebeber
Copy link
Contributor

The current mothAbbr does not follow ISO8601, which is "Mrz" instead of "Mar" in germany.

Please see also datejs implementation: https://github.com/datejs/Datejs/blob/master/build/date-de-DE.js#L9

Another option would be to use "März" instead of "Mrz" - but "Mar" ist not correct.

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Change short form for march in german translation to follow ISO 8601

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Mar 15, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@plainheart plainheart changed the title Update langDE.ts ("Mar" -> "Mrz) fix(i18n): fix the abbr of March for the DE language ("Mar" -> "Mrz) Mar 15, 2023
@plainheart plainheart changed the title fix(i18n): fix the abbr of March for the DE language ("Mar" -> "Mrz) fix(i18n): fix the abbr of "March" for the DE language ("Mar" -> "Mrz) Mar 15, 2023
@plainheart plainheart added this to the 5.5.0 milestone Mar 15, 2023
plainheart
plainheart previously approved these changes Mar 15, 2023
Copy link
Member

@plainheart plainheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing it out!

@plainheart plainheart changed the base branch from release to master March 15, 2023 11:39
@plainheart plainheart dismissed their stale review March 15, 2023 11:39

The base branch was changed.

The current mothAbbr does not follow ISO8601, which is "Mrz" instead of "Mar" in germany.

Please see also datejs implementation: https://github.com/datejs/Datejs/blob/master/build/date-de-DE.js#L9

Another option would be to use "März" instead of "Mrz" - but "Mar" ist not correct.
@plainheart plainheart merged commit 5f49fbb into apache:master Mar 15, 2023
2 checks passed
@echarts-bot
Copy link

echarts-bot bot commented Mar 15, 2023

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart changed the title fix(i18n): fix the abbr of "March" for the DE language ("Mar" -> "Mrz) fix(i18n): fix the abbr of "March" for the DE language ("Mar" -> "Mrz") Mar 16, 2023
@plainheart plainheart modified the milestones: 5.5.0, 5.4.3 Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants