Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type): add undefined to the return type of graphic.clipRectByRect function #18950

Merged
merged 1 commit into from Aug 2, 2023

Conversation

benlongo
Copy link
Contributor

@benlongo benlongo commented Aug 2, 2023

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Add | undefined to return type of graphic.clipRectByRect.

Fixed issues

Details

Before: What was the problem?

graphic.clipRectByRect can return undefined, but this is not reflected in it's type signature.

After: How does it behave after the fixing?

graphic.clipRectByRect has undefined as a possible return type.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Aug 2, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@plainheart plainheart changed the title Fix return type of graphic.clipRectByRect. fix(type): add undefined to the return type of graphic.clipRectByRect function Aug 2, 2023
@plainheart plainheart merged commit 586ca04 into apache:master Aug 2, 2023
@echarts-bot
Copy link

echarts-bot bot commented Aug 2, 2023

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@benlongo benlongo deleted the patch-1 branch August 2, 2023 14:24
@plainheart plainheart added this to the 5.5.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants