[Bug] Changing series type through setOption does not take effect

[hughess]

Version

5.4.3

Link to Minimal Reproduction

https://codesandbox.io/s/stacked-horizontal-bar-forked-f7dss4?file=/index.js

Steps to Reproduce

1. Create a chart
2. Add another call to setOption after the chart is initialized to change some of the settings
3. Change something like the series colour - that works
4. Try changing the series type (e.g., from bar to line)

Current Behavior

When you change attributes of the series, the chart works as expected (e..g, change colour from green to purple).

When you change the series type, the series disappears from the chart. The legend is updated with the correct series type, but the actual chart data is not visible.

Expected Behavior

Should be able to change the series type in the same way you can change the other attributes. Experience should be the same as changing the series type in any of the echarts example pages. E.g., if you go here and change one of these bar series to line it will still work: https://echarts.apache.org/examples/en/editor.html?c=bar-y-category-stack

But if you do the same through a second call to setOption, it will not work

Environment

- OS: Mac
- Browser: N/A
- Framework: N/A

Any additional comments?

I am giving our users a way to override the settings of our chart components by accessing the raw ECharts configuration. I think changing the series type will be a common request. Originally, I was planning to manually merge the settings objects, but was very happy to get it working by letting the user pass their incremental settings to setOption

[MatthiasMert]

As a worksround you can reapply the data property in setOption and it works as expected: Example

[hughess]

Ah great, thanks @MatthiasMert !

[hughess]

Actually this won't work, as our users don't have access to the option object when passing in their options...

[helgasoft]

@hughess, add option = myChart.getOption(); in the click event.
📌 please close issue if problem solved.

[hughess]

Here's the situation I'm trying to solve:

Our users will use one of our chart components, like this:

<LineChart 
   data={query}
   x=month
   y=sales
/>

And this new option will let them override the config for echarts like so:

<LineChart 
   data={query}
   x=month
   y=sales
   echartsOptions={{
      series: [
         {type: 'bar'}
      ]
   }}
/>

In the background, I am taking the echartsOptions prop and passing it into setOption() after the initial config is passed.

If the user includes option in their echartsOptions prop it will throw an error that option is undefined. For example, this will throw an error:

<LineChart 
   data={query}
   x=month
   y=sales
   echartsOptions={{
      series: [
         {type: 'bar', data: option.series.data[0]}
      ]
   }}
/>

[helgasoft]

not-a-bug
looks like a question for a design problem, not an ECharts issue

[hughess]

Why does data need to be re-supplied when changing series.type? Everything else seems to work without that, which is why I would consider this a bug, or at least an inconsistency in the echarts API

[MatthiasMert]

If the user includes option in their echartsOptions prop it will throw an error that option is undefined. For example, this will throw an error.

Why should the user include option in the prop? Can you not pass it on his behalf in the background whenever the series type is changed?

[hughess]

I don't think the user should include option in the prop, but I was also hoping to avoid checking that series.type was passed, since I'll need to get the index for which series they referenced to be able to complete the data update. That approach should work though, so I'll give that a shot!