Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] GrpcSummaryMetrics and TcpSummaryMetrics can share an parent class #3917

Closed
2 tasks done
pandaapo opened this issue May 12, 2023 · 2 comments
Closed
2 tasks done

[Enhancement] GrpcSummaryMetrics and TcpSummaryMetrics can share an parent class #3917

pandaapo opened this issue May 12, 2023 · 2 comments
Labels
enhancement New feature or request
Milestone
1.9.0

Comments

@pandaapo
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

We can design a parent class for GrpcSummaryMetrics and TcpSummaryMetrics as many things in them are the same with each other.

Describe the solution you'd like

Design a parent class for GrpcSummaryMetrics and TcpSummaryMetrics.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@pandaapo pandaapo added the enhancement New feature or request label May 12, 2023
@mxsm
Copy link
Member

mxsm commented May 13, 2023

Hi @pandaapo I hava refactored this module. ISSUE #3430

@pandaapo
Copy link
Contributor Author

pandaapo commented May 13, 2023 •
edited

Hi @pandaapo I hava refactored this module. ISSUE #3430

Oh! I close this now. By the way, the linked pr is truly too large as a single pull request.

@xwm1992 xwm1992 added this to the 1.9.0 milestone Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.9.0
Development

No branches or pull requests
3 participants
@xwm1992 @mxsm @pandaapo